show initial preflight page for helm chart preflights #4402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where the initial install flow preflight page would not be displayed if the application's preflight spec was included in a Secret or ConfigMap within the Helm chart templates.
Key Changes:
kotsKinds
directory for a given app version. We do this on-the-fly when we run preflights, which is why the checks would still run, but not having these saved as part of the kotsKinds in the archive meant that thepreflight_spec
field in the database would not be set, us returninghasPreflight: false
back to the frontend.hasPreflight
field may not be set until the configuration is saved and the version is rendered. This would be the case for a Helm chart that has required configuration, but no default values.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/96941/preflight-page-not-displayed-in-kots-admin-console-install-flow-for-preflight-specs-in-helm-charts
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE