Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show initial preflight page for helm chart preflights #4402

Merged

Conversation

cbodonnell
Copy link
Contributor

@cbodonnell cbodonnell commented Jan 26, 2024

What this PR does / why we need it:

This PR fixes an issue where the initial install flow preflight page would not be displayed if the application's preflight spec was included in a Secret or ConfigMap within the Helm chart templates.

Key Changes:

  • Backend - We were not parsing preflights out of the rendered templates when populating the rendered kotsKinds directory for a given app version. We do this on-the-fly when we run preflights, which is why the checks would still run, but not having these saved as part of the kotsKinds in the archive meant that the preflight_spec field in the database would not be set, us returning hasPreflight: false back to the frontend.
  • Frontend - The application details are now re-fetched after the configuration is saved successfully. This is necessary since the hasPreflight field may not be set until the configuration is saved and the version is rendered. This would be the case for a Helm chart that has required configuration, but no default values.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/96941/preflight-page-not-displayed-in-kots-admin-console-install-flow-for-preflight-specs-in-helm-charts

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue where the initial install flow preflight page would not be displayed if the application's preflight spec was included in a Secret or ConfigMap within the Helm chart templates

Does this PR require documentation?

NONE

@cbodonnell cbodonnell force-pushed the cbo/sc-96941/preflight-page-not-displayed-in-kots-admin branch from ee9bedb to 11318d9 Compare January 30, 2024 17:07
@cbodonnell cbodonnell changed the title wip: show initial preflight page for helm chart preflights show initial preflight page for helm chart preflights Jan 30, 2024
@cbodonnell cbodonnell force-pushed the cbo/sc-96941/preflight-page-not-displayed-in-kots-admin branch from 11318d9 to 4dfe0a2 Compare January 30, 2024 17:08
@cbodonnell cbodonnell added type::bug Something isn't working bug::normal labels Jan 30, 2024
@cbodonnell cbodonnell marked this pull request as ready for review January 30, 2024 17:10
@cbodonnell cbodonnell force-pushed the cbo/sc-96941/preflight-page-not-displayed-in-kots-admin branch from 4dfe0a2 to a45c26f Compare January 30, 2024 21:43
@cbodonnell cbodonnell requested a review from sgalsaleh January 30, 2024 21:48
@cbodonnell cbodonnell requested a review from sgalsaleh February 2, 2024 14:05
@cbodonnell cbodonnell merged commit c124cbd into main Feb 2, 2024
135 checks passed
@cbodonnell cbodonnell deleted the cbo/sc-96941/preflight-page-not-displayed-in-kots-admin branch February 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants